Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option_helpers: improve unit tests for version() #59626

Merged
merged 1 commit into from
Aug 14, 2019
Merged

option_helpers: improve unit tests for version() #59626

merged 1 commit into from
Aug 14, 2019

Conversation

Andersson007
Copy link
Contributor

SUMMARY

options_helpers: improve unit tests for version()

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

option_helpers
lib/ansible/cli/arguments/option_helpers.py

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 26, 2019
@Andersson007 Andersson007 force-pushed the improve_unit_tests_for_optparse_helpers branch from c6a3e7c to 84ef4a4 Compare July 26, 2019 13:27
@ansibot ansibot removed the support:community This issue/PR relates to code supported by the Ansible community. label Jul 26, 2019
@samdoran samdoran requested a review from sivel July 26, 2019 16:10
@samdoran samdoran self-assigned this Jul 30, 2019
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jul 30, 2019
samdoran
samdoran approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a rebase and this is good to merge.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 13, 2019
@Andersson007
optparse_helpers: improve unit tests for version()
aeb70f9 
optparse_helpers: improve unit tests for version()
@Andersson007 Andersson007 force-pushed the improve_unit_tests_for_optparse_helpers branch from 84ef4a4 to aeb70f9 Compare August 14, 2019 05:54
@Andersson007
Copy link
Contributor Author

@samdoran , thank you, done

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 14, 2019
@jimi-c jimi-c merged commit 7955405 into ansible:devel Aug 14, 2019
@ansible ansible locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

@sivel sivel Awaiting requested review from sivel

Assignees

@samdoran samdoran

Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Andersson007 @samdoran @jimi-c @ansibot